Page 2 of 3
Re: Roll20 Data Delve coming 28 May
Posted: Thu May 29, 2014 8:55 pm
by Heilemann
pumpkin wrote:@heilemann, are you taking comments about the character sheet in this thread or through some other method?
We can do it here, works for me.
pumpkin wrote:1. the combat values section don't seem to auto create an corresponding attribute, which means they don't save until you manually create an attribute for them - although maybe i am doing something wrong? this also means the dice roller for armour doesn't work until the attributes it uses are manually created (head-gear etc)
I think I might know the reason for that (the input doesn't have a default value). It should be available for rolls etc. as soon as the input field has a value, be it 0 or something else IIRC. That's not the case?
pumpkin wrote:2. related to the above the formula for generating parry score doesn't seem to work/pick up the wits value
Parry doesn't automatically calculate, if that's what you mean? The reason I didn't do that in some cases is because there are certain things that might give you a bonus to the parry score, and then you won't be able to change it. So I figured it was better to just leave it on manual.
pumpkin wrote:3. Once the favoured weapon box is ticked, that persists (and hence weapon is always underlined) even if tick box is then unchecked... seems to be no way of getting rid of underlining - although again i could be doing it wrong!
Hurr... That sounds odd. I'll take a look; my CSS must be stupid.
pumpkin wrote:4. how do you favour a skill?.
Click the name. I might bust this out into checkboxes, the way it is for Weapon Skills.
pumpkin wrote:overall though, it is looking good and seems to be working well!
Thanks. Keep the feedback coming.
Re: Roll20 Data Delve coming 28 May
Posted: Thu May 29, 2014 9:12 pm
by pumpkin
Heilemann wrote:
I think I might know the reason for that (the input doesn't have a default value). It should be available for rolls etc. as soon as the input field has a value, be it 0 or something else IIRC. That's not the case?
hmmmm.. that seems not the be the case, even though there was a value in for example armour on the main char sheet, it didn't save and the roll calculated as 0 until i'd manually created an armour attribute and put a value in there..i could be doing something screwy, though
Heilemann wrote:Parry doesn't automatically calculate, if that's what you mean? The reason I didn't do that in some cases is because there are certain things that might give you a bonus to the parry score, and then you won't be able to change it. So I figured it was better to just leave it on manual.
ah, ok, the sheet just has @{wits} rather than null in parry on load so it looked like an auto calculate had been added - perhaps you had intended to do this at some point and its not fully cleared?
Heilemann wrote:Click the name. I might bust this out into checkboxes, the way it is for Weapon Skills.
i'm sure i tried that- as the pointer does change on hover over... I'll give it another go!
Thanks for the quick response
Re: Roll20 Data Delve coming 28 May
Posted: Fri May 30, 2014 3:41 am
by Heilemann
Created a pull request for some fixes just now; should be in Roll20 in a day or two I hope.
Re: Roll20 Data Delve coming 28 May
Posted: Fri May 30, 2014 9:32 am
by pumpkin
Ace!
I tried clicking on skill name to make it favoured and that seemed to be faulty, was that one of the fixes?
Also, weapon skills for adversary rolls seem to suffer from similar issue - the corresponding attribute isn't created so the macro doesn't function.. Skills work fine though
I'll give the new sheet a whirl once it is there
Cheers, lee
Re: Roll20 Data Delve coming 28 May
Posted: Fri May 30, 2014 12:37 pm
by Heilemann
Not sure I understand the Weapon Skill issue you're talking about.
Yes, I fixed the favoured skill issue. If you open just one sheet, it's not a problem. Once you've opened two; it breaks
![Smile :)](images/smilies/icon_e_smile.gif)
Re: Roll20 Data Delve coming 28 May
Posted: Fri May 30, 2014 2:38 pm
by pumpkin
sorry, the weapon skills issue for adversaries is similar to the armour issue for the PC character sheet - the weapon rating doesn't get created as an attribute even though there is a value on the main sheet so the macro has nothing to reference - pressing the roll button for the weapon skill effectively does nothing, nothing appears on chat window at all - so slightly different actually?
The value of the weapon rating on the main sheet does persist when the sheet is closed and the favoured buttons work fine on the adversary sheet, just the macro rolls aren't functioning and i think its because there isn't an associated attribute in the list again...
make more sense now?
edit: also doesn't work for LM character sheets - weapons added dont created attributes so macros have nothing to reference - DOES work for pc sheets though, all of the corresponding weapon attributes are created when a new weapon is added to the main sheet and so the macros all work
Re: Roll20 Data Delve coming 28 May
Posted: Fri May 30, 2014 3:01 pm
by Heilemann
It's not the sheet, but the system. You can try asking on the CharSheet forums at Roll20:
https://app.roll20.net/forum/post/88817 ... ost-888339
Re: Roll20 Data Delve coming 28 May
Posted: Fri May 30, 2014 4:24 pm
by pumpkin
Ah, so what's the issue with the system itself?
What should I report in the roll20 forums?
Re: Roll20 Data Delve coming 28 May
Posted: Fri May 30, 2014 5:26 pm
by Heilemann
That macros can't reference repeatable field values, I think.
Re: Roll20 Data Delve coming 28 May
Posted: Fri May 30, 2014 7:41 pm
by pumpkin
Heilemann wrote:That macros can't reference repeatable field values, I think.
yer, cool, that
is working on the PC sheet i think, so i wonder if it is broken only on subsequent multiple sheets accessed via the radio buttons?
I'll put something on the roll20 forums and see what we get anyway
Cheers